refactor: extract cropByBBox logic and prevent overflow panics
#398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
yisibl
force-pushed
the
refactor-crop_by_bbox
branch
from
1726ce8 to
ac6ba9a
Compare
yisibl
force-pushed
the
refactor-crop_by_bbox
branch
from
ac6ba9a to
f07b0fe
Compare
yisibl
force-pushed
the
refactor-crop_by_bbox
branch
from
f07b0fe to
4777fd3
Compare
yisibl
force-pushed
the
refactor-crop_by_bbox
branch
from
4777fd3 to
307dca2
Compare
yisibl
force-pushed
the
refactor-crop_by_bbox
branch
from
307dca2 to
a75b804
Compare
yisibl
changed the title
cropByBBox logic and prevent overflow panics
yisibl
force-pushed
the
refactor-crop_by_bbox
branch
from
a75b804 to
3f09edf
Compare
- Add `CropContext/CropResult` structs to encapsulate crop calculations - Extract `crop_by_bbox_inner()` for shared NAPI/WASM implementation - Performance optimization: Add `cropped_empty` flag to skip rendering when crop yields no visible content - Skip resvg rendering for empty crops to avoid IntRect overflow panics - Move cropByBBox tests to dedicated `index-bbox.spec.ts`
yisibl
force-pushed
the
refactor-crop_by_bbox
branch
from
3f09edf to
5be47bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CropContext/CropResultstructs to encapsulate crop calculationscrop_by_bbox_inner()for shared NAPI/WASM implementationcropped_emptyflag to skip rendering when crop yields no visible contentindex-bbox.spec.ts