Shutdown on Ctrl+C and SIGTERM #10
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the program would only exit once all spawned tasks had completed. With the new behavior, the program also quits if either
Ctrl-CorSIGTERMis received. The advantage is that operations such asdocker compose restartnow complete almost immediately. Previously, a graceful shutdown request sent by Docker viaSIGTERMhad no effect, causing a 10-second wait before Docker forcefully killed the previous instance.This solution is not perfect, since all spawned tasks are effectively terminated when the main function returns. However, it is not a step back from the previous behavior — termination now simply happens sooner.
I tested both shutdown methods and have deployed this change locally. On that note, thanks for creating this project!