qmake: Get Qt version check in sync with its documented intention#158
Conversation
13fc3f8 to
d33bce8
Compare
|
To be pedantic, |
|
@tibirna the messaging and in-code comment further up both indicate that >=4.8.0 is wanted but the code is actually checking for >4.8.0 without allowing for =4.8.0. The fix gets that back in sync. |
|
@hartwork TBH, I have no idea what is the actual requirement (which is also why I didn’t bother changing that to match). But perhaps it is better to make it coherent to avoid confusion. If someone ever tries to build this with Qt 4.8.0 and that happens not to work, they could open an issue. |
|
@barracuda156 good to know. My mission here was just to make the code do what the comments say it's supposed to do. Maybe that's a good start? |

CC @tibirna @barracuda156