-
-
Notifications
You must be signed in to change notification settings - Fork 4
[WEB-3841] PDF bolus limit #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a bolus limit feature for PDF exports to prevent overflowing the allowed height in daily print views. The change limits 3-hour binned bolus lists to 50 entries to address layout issues in PDF generation.
- Updates package version to include WEB-3841 bolus limit feature
- Updates @tidepool/viz dependency to version with corresponding bolus limit implementation
clintonium-119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
/deploy qa1 |
|
krystophv updated values.yaml file in qa1 |
|
krystophv updated flux policies file in qa1 |
|
krystophv deployed export WEB-3841-pdf-bolus-limit branch to qa1 namespace |
for WEB-3841, limits 3-hr binned bolus lists in the daily print view to 50 to avoid overflowing the allowed height
alongside tidepool-org/blip#1724 and tidepool-org/viz#529