Open
Conversation
toddkazakov
reviewed
Nov 3, 2020
| select { | ||
| case <-timer.C: | ||
| break | ||
| case <-session.Context().Done(): |
Contributor
There was a problem hiding this comment.
Is the context terminated when a rebalance happens?
toddkazakov
reviewed
Nov 3, 2020
events/config.go
Outdated
| KafkaUsername string `envconfig:"KAFKA_USERNAME" required:"false"` | ||
| KafkaPassword string `envconfig:"KAFKA_PASSWORD" required:"false"` | ||
| KafkaDelay int `envconfig:"KAFKA_DELAY" default:"0"` | ||
| CascadeDelays []int `envconfig:"KAFKA_CASCADE_DELAYS" default:""` |
Contributor
There was a problem hiding this comment.
I think envocnfig supports parsing time.Duration out of the box, so it should be possible to use it directly, instead of int.
Should we provide sensible defaults?
toddkazakov
reviewed
Nov 3, 2020
Contributor
toddkazakov
left a comment
toddkazakov
left a comment
There was a problem hiding this comment.
Looks good - just make sure rebalancing is handled correctly
Contributor
Author
|
I added support for exponential backoff retries. |
toddkazakov
previously approved these changes
Nov 7, 2020
Contributor
toddkazakov
left a comment
toddkazakov
left a comment
There was a problem hiding this comment.
Code looks good to me. Can you please test this before merging?
Contributor
Author
|
Of course thx.
Derrick
…On Nov 6, 2020, 7:05 PM -0800, Todd Kazakov ***@***.***>, wrote:
@toddkazakov approved this pull request.
Code looks good to me. Can you please test this before merging?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@todd I have not tested this yet. I just want to get your eyes on it to see if you a better approach.