remove platform specific bits from Todd's cascading import#79
Open
ewollesen wants to merge 1 commit intotk-cascading-retryfrom
Open
remove platform specific bits from Todd's cascading import#79ewollesen wants to merge 1 commit intotk-cascading-retryfrom
ewollesen wants to merge 1 commit intotk-cascading-retryfrom
Conversation
While Todd did the Lion's share of the work, some of what was imported was specific to platform and won't generalize well for other projects. In addition, now that I can see what other uses of the cascading retry consumer might look like, I've re-worked some of the adapters to better be able to service platform, clinic-worker, or other possible services in the future. Of particular note: - remove SaramaRunner from go-common, it is platform specific - add BlockingStartStopAdapter - add NonBlockingStartStopAdapter - go over all the names again and work on their consistency
Contributor
Author
|
Notably still to do is to bring the cascading tests over from my platform branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While Todd did the Lion's share of the work, some of what was imported was specific to platform and won't generalize well for other projects.
In addition, now that I can see what other uses of the cascading retry consumer might look like, I've re-worked some of the adapters to better be able to service platform, clinic-worker, or other possible services in the future.
Of particular note: