Skip to content

[BACK-3478] Add client calls for scheduled email notifications.#82

Open
lostlevels wants to merge 5 commits intomasterfrom
jimmy-device-email-notifications
Open

[BACK-3478] Add client calls for scheduled email notifications.#82
lostlevels wants to merge 5 commits intomasterfrom
jimmy-device-email-notifications

Conversation

@lostlevels
Copy link

No description provided.

Copy link
Contributor

@darinkrauss darinkrauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts...

Copy link
Contributor

@darinkrauss darinkrauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit. Approved.

Copy link
Contributor

@darinkrauss darinkrauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the build is failing. I think you need to update the vendor directory.

Copy link
Contributor

@darinkrauss darinkrauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants