Closed
Conversation
Current coverage is 99.59% (diff: 100%)@@ master #187 diff @@
==========================================
Files 16 16
Lines 738 738
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 735 735
Misses 3 3
Partials 0 0
|
Member
|
Could you please also add the appropriate tests to travis to ensure that we don't accidentally regress? I'm happy to enforce the principle that tidyverse packages should work with R 3.0 |
Member
|
Member
|
Closing in favor of #209. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried basic
tibblefunctionality with3.1.0and could not spot any issues. Also tried with3.0.0but it depends onlazyevalwhich requires3.1.0since it depends on this addition wch/r-source@2e5fdef and therefore, supporting3.0.0would require additional work inlazyeval.NOTE: Dependent on hadley/lazyeval#87
Fixes #189.