fix: fine grained lock in smoltcp #265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is one of a series of PRs that consolidates #252. This PR implements socket-level locking.
A straightforward approach would be to wrap both meta and socket defined here with Mutex. However, this would make it difficult to return pre-lock objects in SocketSet methods like get() and iter() defined in the same file. Therefore, wrapping each member variable in these structures (meta, socket ) with locks and modifying the rest of the code to accommodate this structure.
Related links
PR #252
How was this PR tested?
In applications/tests/test_network, verified:
Notes for reviewers
I would appreciate any feedback on these implementation decisions.