Keep the leading slash in pretty output path for index files #754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that
$this->outputPathResolver->link()would generate path without a leading slash for index files, e.g. index.blade.php, index.html, index.md, when using pretty urls (which is the default!)This causes problem when we have
source/blog/index.blade.phpinstead ofsource/blog.blade.php.link()would returnblogfor the former file, and return/blogfor the latter file.For example, GenerateSitemap.php from the blog template would generate the following if having
source/blog/index.blade.phpI have traced back to the commit 7aa603a#diff-76e91e6d5ebc8f831ce78c19c83441aa3b719af6a3d4098823f9195a639ec285R11 that introduced the change, and I think it was merely a bug,
ltrim()should be applied right before$this->trimPath().