feat(storage): updateBucket method #55
Conversation
Greptile SummaryAdded Major changes:
Issues found:
Confidence Score: 3/5
Important Files Changed
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| export type UpdateBucketOptions = { | ||
| access?: 'public' | 'private'; | ||
| consistency?: 'strict' | 'default'; |
There was a problem hiding this comment.
Don't add this option. We will be deprecating this soon in favor of some new options.
There was a problem hiding this comment.
Sounds good, I will mark also mark it as deprecated in createBucket method.
There was a problem hiding this comment.
Don't mark it deprecated right now. For that we can do it once we rollout changes on console.
| import { createStorageClient } from '../http-client'; | ||
| import type { TigrisStorageConfig, TigrisStorageResponse } from '../types'; | ||
|
|
||
| export type UpdateBucketOptions = { |
There was a problem hiding this comment.
There are some other options as well like object notification, object lifecycle. But we can add those incrementally.
There was a problem hiding this comment.
Correct, I guess I will add those here in this same PR.
|
🎉 This PR is included in version 1.0.10 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.4 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Note
Introduces bucket update functionality and credential-based authentication flow.
updateBucket(PATCH/<bucket>) supports ACL, directory listing toggle, regions, cache-control, custom domain, and delete protectionshared/http-client: adds AWS SigV4 signing via@smithy/signature-v4and@aws-crypto/sha256-js; uses credentials (accessKeyId/secretAccessKey) when no session token; improves request body handling and response parsing; updates client cache keypackages/storage/lib/http-client: allows either session token or access key credentials; validatesorganizationIdwhen using session tokenshared/headers: addsACL,ACL_LIST_OBJECTS,AUTHORIZATION, and fork snapshot headersupdateBucketfrompackages/storage/src/server.ts@tigrisdata/storageWritten by Cursor Bugbot for commit 5d37455. This will update automatically on new commits. Configure here.