Skip to content

feat(iam): access key operations #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
designcode wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(iam): access key operations #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa8a8dc
chore(ci): remove multi-semantic-release package
designcode Jan 22, 2026
821a2b7
feat(iam): implement access key methods
designcode Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@
"prefer-const": "error",
"no-var": "error"
},
"ignorePatterns": ["dist/", "node_modules/"]
"ignorePatterns": ["dist/", "node_modules/", "*.cjs"]
}
6 changes: 3 additions & 3 deletions .github/workflows/javascript.yaml → .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: JavaScript tests
name: Pull Request Checks

on:
pull_request:
Expand All @@ -7,7 +7,7 @@ on:
- next

jobs:
javascript_tests:
checks:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
Expand All @@ -17,7 +17,7 @@ jobs:
# Set up Node.js
- uses: actions/setup-node@v4
with:
node-version: "latest"
node-version: 'latest'

- name: Install Dependencies
run: npm ci
Expand Down
16 changes: 6 additions & 10 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
with:
fetch-depth: 0

# Set up Node.js
# Set up Node.js with npm provenance
- uses: actions/setup-node@v4
with:
node-version: '22'
Expand All @@ -32,27 +32,23 @@ jobs:
- run: npm run lint

- name: Build packages
run: |
npm run build
run: npm run build

- name: Lint packages
run: |
npm run publint
run: npm run publint

- name: Test packages
env:
TIGRIS_STORAGE_BUCKET: ${{ secrets.TIGRIS_STORAGE_BUCKET }}
TIGRIS_STORAGE_ACCESS_KEY_ID: ${{ secrets.TIGRIS_STORAGE_ACCESS_KEY_ID }}
TIGRIS_STORAGE_SECRET_ACCESS_KEY: ${{ secrets.TIGRIS_STORAGE_SECRET_ACCESS_KEY }}
TIGRIS_STORAGE_ENDPOINT: ${{ secrets.TIGRIS_STORAGE_ENDPOINT }}
run: |
npm run test
run: npm run test

- run: npm audit signatures

# Release to GitHub and NPM
# Release packages in dependency order
- name: Release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: npm run release
run: ./scripts/release.sh
Comment on lines 52 to +54
Copy link

@greptile-apps greptile-apps bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM_TOKEN environment variable was removed but @semantic-release/npm plugin still requires authentication to publish packages to npm. The workflow will fail when attempting to publish.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: .github/workflows/release.yaml
Line: 52:54

Comment:
NPM_TOKEN environment variable was removed but @semantic-release/npm plugin still requires authentication to publish packages to npm. The workflow will fail when attempting to publish.

How can I resolve this? If you propose a fix, please make it concise.

Copy link

@cursor cursor bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing NPM_TOKEN breaks npm package publishing

High Severity

The NPM_TOKEN environment variable was removed from the Release step, but @semantic-release/npm is still configured as a plugin in release.config.base.cjs. Without NPM_TOKEN, the npm publish step will fail with an authentication error, preventing any packages from being published to npm.

Fix in Cursor Fix in Web

Loading