Skip to content

*: Re-export protobuf types (LockInfo, Error, and KeyError) #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 3 commits into from
Jan 22, 2026
Merged

*: Re-export protobuf types (LockInfo, Error, and KeyError) #526

ti-chi-bot merged 3 commits into from
Jan 22, 2026
+40 −11

Conversation

@pingyu
Copy link
Collaborator

@pingyu pingyu commented Jan 21, 2026 •
edited
Loading

Changes

  • Publicly re-export protobuf-generated types from the crate to provide a stable, ergonomic API surface.
  • Update internal function signatures to use the re-exported type names.
  • Adjust From/conversion implementations to match the new public type names.
  • No behavioral or wire-format changes; underlying protobuf types remain the same.

@pingyu
transaction: Re-export kvrpcpb::LockInfo
d0c8b06 
Signed-off-by: Ping Yu <yuping@pingcap.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2026
pingyu added 2 commits January 21, 2026 22:53
@pingyu
pub
5b16922 
Signed-off-by: Ping Yu <yuping@pingcap.com>
@pingyu
re-export proto error
285cd09 
Signed-off-by: Ping Yu <yuping@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2026
@pingyu pingyu changed the title transaction: Re-export kvrpcpb::LockInfo for scan_locks/resolve_locks *: Re-export protobuf types and align internal APIs Jan 22, 2026
@pingyu pingyu changed the title *: Re-export protobuf types and align internal APIs *: Re-export protobuf types (LockInfo, Error, and KeyError) Jan 22, 2026
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 22, 2026
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coocood, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-22 02:08:40.614554438 +0000 UTC m=+632548.228511304: ☑️ agreed by coocood.
  • 2026-01-22 02:58:09.474453616 +0000 UTC m=+635517.088410462: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 9d9b680 into tikv:master Jan 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coocood coocood coocood approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pingyu @coocood @YuJuncen