Skip to content

Allow default (not-set) values in diagram render options #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasbindreiter merged 1 commit into from
Jul 29, 2025
Merged

Allow default (not-set) values in diagram render options #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apis/workflows/v1/diagram.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// Diagram service for rendering diagrams

edition = "2023";
Expand All @@ -22,6 +22,7 @@
// "dagre" or "elk". Defaults to "dagre"
string layout = 1 [(buf.validate.field).string = {
in: [
"", // if not set, defaults to "dagre"
"dagre",
"elk"
]
Expand All @@ -39,6 +40,7 @@
// Set explicitly the direction of the diagram: https://d2lang.com/tour/layouts/#direction.
string direction = 5 [(buf.validate.field).string = {
in: [
"", // if not set, defaults to the d2 default, which is "down"
"up",
"down",
"right",
Expand Down
4 changes: 2 additions & 2 deletions buf.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
version: v2
deps:
- name: buf.build/bufbuild/protovalidate
commit: c923a0c2a1324d8b9db81effea973b9c
digest: b5:ba54835683c74e87e751bdc482b7d1c157926024587f453ca3640d3348b846aba3244da145042226842e10876a856e19b6dffc96609167199a450455aef9acf3
commit: 6c6e0d3c608e4549802254a2eee81bc8
digest: b5:a7ca081f38656fc0f5aaa685cc111d3342876723851b47ca6b80cbb810cbb2380f8c444115c495ada58fa1f85eff44e68dc54a445761c195acdb5e8d9af675b6
- name: buf.build/googleapis/googleapis
commit: 61b203b9a9164be9a834f58c37be6f62
digest: b5:7811a98b35bd2e4ae5c3ac73c8b3d9ae429f3a790da15de188dc98fc2b77d6bb10e45711f14903af9553fa9821dff256054f2e4b7795789265bc476bec2f088c
Loading