This repository was archived by the owner on Oct 5, 2025. It is now read-only.
S3 credentials enhancements and fix URL parsing#76
Merged
Conversation
S3 credential enhancements: - Add USE_DEFAULT_CREDENTIALS_PROVIDER parameter (default: false for public access) - Add DEFAULT_CREDENTIALS_PROFILE parameter for custom AWS profiles - Use AnonymousCredentialsProvider for unsigned requests to public S3 resources - Enable reuseLastProviderEnabled and asyncCredentialUpdateEnabled for server optimization - Add comprehensive Javadoc for all credential-related builder methods Restrict S3RangeReaderProvider to files only and add public S3 access support - S3RangeReaderProvider now requires both non-empty bucket AND key to claim URLs - This ensures RangeReader only handles URLs pointing to specific files, not bucket roots - Custom domain URLs like demo-bucket.protomaps.com now fall back to HttpRangeReader - Updated tests to reflect that bucket root URLs should use HTTP, not S3 client - Maintains support for legitimate S3-compatible services (MinIO, etc.) with file paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 credential enhancements:
Restrict S3RangeReaderProvider to files only and add public S3 access support