Introduce permanent storage and random user tokens#7
Introduce permanent storage and random user tokens#7Maschina wants to merge 14 commits intotim-hellhake:masterfrom
Conversation
Create LICENSE
tim-hellhake
left a comment
tim-hellhake
left a comment
There was a problem hiding this comment.
Awesome work!
I have just a few comments.
| dist | ||
| .vscode | ||
| hue.json | ||
| package-lock.json |
There was a problem hiding this comment.
| package-lock.json |
There was a problem hiding this comment.
Please add an updated package-lock.json.
| "dependencies": { | ||
| "express": "^4.17.1", | ||
| "body-parser": "^1.19.0" | ||
| "bluebird": "^3.7.2", |
There was a problem hiding this comment.
Is this actually used in the code?
| let map: {[key: string]: string} = {}; | ||
| map[address] = message; | ||
| return [{ | ||
| success: map | ||
| }]; |
There was a problem hiding this comment.
| let map: {[key: string]: string} = {}; | |
| map[address] = message; | |
| return [{ | |
| success: map | |
| }]; | |
| return [{ | |
| success: {[address]: message} | |
| }]; |
|
|
||
| export function getIsoDateTime(): string { | ||
| var dateFormat = require('dateformat'); |
There was a problem hiding this comment.
| export function getIsoDateTime(): string { | |
| var dateFormat = require('dateformat'); | |
| import dateformat from 'dateformat'; | |
| export function getIsoDateTime(): string { |
npm install --save-dev @types/dateformat
| import { HueBridge } from './hue-bridge'; | ||
|
|
||
| let bridge = new HueBridge({ debug: true }); | ||
| bridge.start(); No newline at end of file |
There was a problem hiding this comment.
| import { HueBridge } from './hue-bridge'; | |
| let bridge = new HueBridge({ debug: true }); | |
| bridge.start(); | |
| export * from './hue-bridge' |
It should be still usable as a library.
I'm totally fine if you add something like a server.js.
| { | ||
| "defaultSeverity": "error", | ||
| "extends": [ | ||
| "tslint:recommended" | ||
| ], | ||
| "jsRules": {}, | ||
| "rules": { | ||
| "no-unnecessary-type-assertion": true, | ||
| "array-type": [true, "array"], | ||
| "no-double-space": true, | ||
| "no-var-keyword": true | ||
| }, | ||
| "rulesDirectory": [] | ||
| } No newline at end of file |
@tim-hellhake |
I would update this PR but if it's easier to open a new PR feel free. |
2 participants
No description provided.