Add RWMutex to logger to prevent data races on concurrent access#17
Merged
doron-sincere merged 1 commit intomasterfrom Apr 3, 2026
Merged
Add RWMutex to logger to prevent data races on concurrent access#17doron-sincere merged 1 commit intomasterfrom
doron-sincere merged 1 commit intomasterfrom
Conversation
- Protect level, flags, staticArgs, and output fields with sync.RWMutex - Log methods take RLock for level checks and output - Set methods take exclusive Lock
AObuchow
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.RWMutexto theloggerstruct to make concurrent access safeRLockfor level checks and outputLocksync.RWMutexzero value is unlocked, so no constructor changes needed