Fix error handling in redisurl + migrate tests to stdlib#22
Merged
Conversation
- return explicit error values instead of naked returns - handle error from SELECT command when switching databases
- return nil on parse/dial errors for consistency - return connection with error after dial for caller-managed cleanup - add support for newer Redis AUTH error message - use errors.Is() for error checking in pool - add tests for error cases
- rewrite pool, connection, and convert tests using t.Run subtests - delete redis_suite_test.go ginkgo boilerplate - apply range-over-integers modernization (4 loops) - use t.Cleanup for auth setup/teardown
doron-sincere
changed the title
AObuchow
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redisurl error handling
test modernization
testingwitht.Runsubtestst.Cleanupfor auth setup/teardown