This repository was archived by the owner on Jan 18, 2024. It is now read-only.
charts/multinode: fixed auth on newer images(#341)#362
Merged
paulfantom merged 2 commits intotimescale:masterfrom May 30, 2022
AlbertoPimpo:master
Merged
charts/multinode: fixed auth on newer images(#341)#362paulfantom merged 2 commits intotimescale:masterfrom AlbertoPimpo:master
paulfantom merged 2 commits intotimescale:masterfrom
AlbertoPimpo:master
Conversation
|
Great! Works as expected. LGTM ?! |
feikesteenbergen
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the current state, the multinode chart don't work with any recent image because they are configured in order to allow connection only from localhost, and this obviusly break any multinode configuration (#341).
The approach to solve this problem is similar to #311 , but instead of allowing every IP of the cluster without any authentication, this PR will allow md5 authentication, in the same way older images does. This approach has the advantage that works with any configuration and doesn't require extra configuration in values.yaml file.