Add e2e docker-compose for quick start#1471
Conversation
VineethReddy02
changed the title
VineethReddy02
force-pushed
the
quick-start-example
branch
from
2da352d to
564f3c8
Compare
| - "16686:16686" | ||
|
|
||
| grafana: | ||
| image: vineeth97/promscale-demo-grafana |
There was a problem hiding this comment.
I will update this image to timescale repo. At the moment we do not have credentials for the repo.
I will create a follow-up PR to update the repo, once the image is published.
There was a problem hiding this comment.
Who will manage this image in the long run?
Is the team fine with creation of tech-debt in form of such image and if so is there a plan to switch back to "official" grafana image in the long run? If there is such plan, can we have an issue referenced in the code comment?
There was a problem hiding this comment.
My plan is to publish my image as timescale/promscale-demo-grafana. As this image will contain all the required dashboards and data sources pre-configured. The same is added to the otel-demo repo here.
There was a problem hiding this comment.
@paulfantom I have created an issue and assigned it to myself to track this as a backlog.
There was a problem hiding this comment.
This is still in the repo as vineeth97/promscale-demo-grafana it's not a good look specially if we want customers to run this on their machines.
paulfantom
left a comment
paulfantom
left a comment
There was a problem hiding this comment.
From technical POV this lgtm. My only concern is about using a grafana image that is not an official one.
paulfantom
left a comment
paulfantom
left a comment
There was a problem hiding this comment.
From technical POV this lgtm. My only concern is about using a grafana image that is not an official one.
4 participants
Description
Quick start docker-compose to start all the required components alongside Promscale to get the e2e experience with Promscale.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: