CustomDialog checks for an existing binding of IsOpen before setting it; fixes #244#245
Open
mbruckner wants to merge 1 commit intotimheuer:devfrom
mbruckner:dev
Open
CustomDialog checks for an existing binding of IsOpen before setting it; fixes #244#245mbruckner wants to merge 1 commit intotimheuer:devfrom mbruckner:dev
mbruckner wants to merge 1 commit intotimheuer:devfrom
mbruckner:dev
Conversation
mbruckner
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible fix/workaround for the problem described at #244, which causes an MVVM usage of CustomDialog to break. The binding for IsOpen is overridden when the Back button is handled using the Command parameter instead of the click handler.
Note: This will break previously working code, if a binding was used to just open the dialog.