Skip to content

Fixes #235. #256

Open
JoshClose wants to merge 2 commits intotimheuer:masterfrom
JoshClose:fix-235
Open

Fixes #235. #256
JoshClose wants to merge 2 commits intotimheuer:masterfrom
JoshClose:fix-235

Conversation

@JoshClose
Copy link
Copy Markdown

Resizes the dialog when the keyboard is shown. Also added a ScrollViewer so when the dialog is larger than the visible area, you can scroll and see all the content.

…so added a ScrollViewer so when the dialog is larger than the visible area, you can scroll.
@JoshClose
Copy link
Copy Markdown
Author

Looks like there are white space differences, so sorry about that.

@yzhong52
Copy link
Copy Markdown

This totally works, how come it is not merged to master?

@JoshClose
Copy link
Copy Markdown
Author

Tim is probably really busy. I know I haven't given my OSS project much love lately due to busyness.

@yzhong52
Copy link
Copy Markdown

But one issue is that the code indention is very weird. Not sure what text editor you are using. Could you possibly fix that?

@yzhong52
Copy link
Copy Markdown

Yeah, I can see that last changes are over a year ago. He is probably not maintaining this project now. Sad :(

@JoshClose
Copy link
Copy Markdown
Author

Btw, if you tack on ?w=1 to the end of the URL when viewing file diffs, it'll ignore whitespace.

@JoshClose
Copy link
Copy Markdown
Author

I used visual studio. If he wants to change that, he can probably just do a one click format in VS to change it to his preferences.

@timheuer
Copy link
Copy Markdown
Owner

I'm maintaining, just very very busy lately and don't want to blindly merge
and release without ensuring that I take into account other changes that
are in-flight.


http://timheuer.com/blog/
twitter: @timheuer

On Thu, Jul 30, 2015 at 9:05 AM, Josh Close notifications@github.com
wrote:

I used visual studio. If he wants to change that, he can probably just do
a one click format in VS to change it to his preferences.


Reply to this email directly or view it on GitHub
#256 (comment).

@yzhong52
Copy link
Copy Markdown

👍 Nice to hear about that. And thanks for getting back to us Tim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants