Add device config for Fröling BWP300PV#160
Open
itsh-neumeier wants to merge 1 commit intotimlaing:mainfrom
Open
Add device config for Fröling BWP300PV#160itsh-neumeier wants to merge 1 commit intotimlaing:mainfrom
itsh-neumeier wants to merge 1 commit intotimlaing:mainfrom
Conversation
Adds a new device configuration for the Fröling BWP300PV domestic hot water heat pump (Austrian manufacturer Fröling). The BWP300PV is an OEM model of the German company 1EcoDesign.
Contributor
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis pull request introduces a new YAML configuration file for the Fröling BWP300 PV Modbus local gateway device. The configuration defines input and holding register mappings for 71 sensors, binary sensors, temperature controls, scheduling parameters, and operational modes to Home Assistant entities. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (2)
custom_components/modbus_local_gateway/device_configs/Fröling_BWP300PV.yaml (2)
174-181:multiplier: 1is redundant onfw_version.A multiplier of
1is a no-op; omitting it simplifies the entry and matches the style of other non-scaled registers in this file.♻️ Proposed cleanup
fw_version: name: "FW Version" icon: mdi:chip address: 119 - multiplier: 1 precision: 0 entity_category: diagnostic entity_registry_enabled_default: true🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@custom_components/modbus_local_gateway/device_configs/Fröling_BWP300PV.yaml` around lines 174 - 181, The fw_version register entry includes a redundant multiplier: 1; remove the multiplier property from the fw_version block (the YAML map keyed by fw_version) so the entry matches other non-scaled registers and stays concise, leaving name, icon, address, precision, entity_category, and entity_registry_enabled_default intact.
571-571: Remove development artefact comment# Icons ergänzt.This inline note is a leftover from authoring and adds no value in the shipped config.
♻️ Proposed cleanup
- entity_registry_enabled_default: true # Icons ergänzt + entity_registry_enabled_default: true🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@custom_components/modbus_local_gateway/device_configs/Fröling_BWP300PV.yaml` at line 571, Remove the development artefact comment from the YAML entry by deleting the inline comment text "# Icons ergänzt" on the entity_registry_enabled_default line so the line reads only "entity_registry_enabled_default: true"; ensure you only remove the comment and do not alter the key name or its boolean value (reference: entity_registry_enabled_default).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@custom_components/modbus_local_gateway/device_configs/Fröling_BWP300PV.yaml`:
- Line 286: The displayed "name" value contains a typo: change the YAML entry
where name is set to "Betriebsmodus: Standart" to "Betriebsmodus: Standard";
locate the name key in the Fröling_BWP300PV.yaml configuration and update the
string (preserving the Umlaut in "Betriebsmodus") so the UI shows the corrected
spelling.
- Line 139: Replace the misspelled YAML entity key "holyday_remaining_days" with
the correct spelling "holiday_remaining_days" wherever it appears in this device
config (the key name under the Fröling_BWP300PV configuration); update any
corresponding references or mappings that use the "holyday_remaining_days"
identifier so they now point to "holiday_remaining_days" to avoid breaking
entity IDs in Home Assistant.
- Around line 401-404: Update the German plural forms in the YAML list entries:
locate the entries currently set to "2 Woche" and "3 Woche" and change them to
"2 Wochen" and "3 Wochen" respectively so the plural inflection is correct for
the keys labeled 2 and 3 in the Fröling_BWP300PV configuration.
- Around line 115-137: The comment above the status.flags block is misleading:
it says "BIT-POSITIONEN (0..15)" but the mapping uses bitmask values
(1,2,4,8,...). Update the comment to state these are bitmask values (e.g.,
"BITMASK VALUES (2^n) / bit positions 0..15 represented as 1,2,4,...") and then
verify whether the bitmask for value 16 (the 4th bit) should exist; if it was
omitted accidentally, add an entry "16: <label>" under the status.flags mapping,
otherwise confirm intentionally omitted and document that in the comment. Ensure
you modify the status.flags block (not other keys) to keep labels and
entity_registry_enabled_default unchanged.
- Around line 149-165: The alarm flags in the "alarm" register use sequential
integers (0,1,2...) but the framework expects bitmask values like the "status"
register; update the keys under the alarm mapping (symbol: alarm) to bitmask
values (1, 2, 4, 8, 16, 32, 64, 128, 256) matching the convention used by status
so the bitwise checks work correctly, and verify entity_registry_enabled_default
and address remain unchanged.
- Around line 139-147: The entity holyday_remaining_days declares device_class:
duration but uses an invalid unit_of_measurement "Tag/e"; update the
unit_of_measurement for holyday_remaining_days to the Home Assistant-approved
duration unit "d" so it matches device_class: duration and avoids validation
warnings.
---
Nitpick comments:
In `@custom_components/modbus_local_gateway/device_configs/Fröling_BWP300PV.yaml`:
- Around line 174-181: The fw_version register entry includes a redundant
multiplier: 1; remove the multiplier property from the fw_version block (the
YAML map keyed by fw_version) so the entry matches other non-scaled registers
and stays concise, leaving name, icon, address, precision, entity_category, and
entity_registry_enabled_default intact.
- Line 571: Remove the development artefact comment from the YAML entry by
deleting the inline comment text "# Icons ergänzt" on the
entity_registry_enabled_default line so the line reads only
"entity_registry_enabled_default: true"; ensure you only remove the comment and
do not alter the key name or its boolean value (reference:
entity_registry_enabled_default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new device configuration for the Fröling BWP300PV domestic hot water heat pump (Austrian manufacturer Fröling). The BWP300PV is an OEM model of the German company 1EcoDesign.