Skip to content

HOK-1403_c: Suppress branch deletion messages from task backlog pane#374

Merged
timogilvie merged 2 commits intomainfrom
task/deleted-branch-messages-appearing-in-task-backlog-pane-challenger
Apr 23, 2026
Merged

HOK-1403_c: Suppress branch deletion messages from task backlog pane#374
timogilvie merged 2 commits intomainfrom
task/deleted-branch-messages-appearing-in-task-backlog-pane-challenger

Conversation

@timogilvie
Copy link
Copy Markdown
Owner

Summary

  • Suppressed branch deletion confirmation messages from appearing in the task backlog pane
  • Changed messages to debug level so they only appear in logging output, not UI
  • Added test harness stubs for _restore_inflight_task_window_if_missing function

Changes

  • shared/lib/wavemill-mill.sh: Changed 4 branch cleanup log calls from standard logging to debug level:
    • Window closure message
    • Worktree removal message
    • Local branch deletion message
    • Remote branch deletion message
  • tests/lifecycle-harness.test.sh: Added stub for _restore_inflight_task_window_if_missing
  • tests/lifecycle-scenarios.test.sh: Added stub for _restore_inflight_task_window_if_missing

Test plan

  • Self-review passed with no blockers
  • Changes maintain existing behavior while suppressing UI messages
  • Test stubs support harness infrastructure

Self-review

  • Verdict: ready
  • 0 iterations needed
  • No code issues or warnings found

timogilvie and others added 2 commits April 22, 2026 21:26
Downgrade cleanup detail log calls in cleanup_completed_task() from
info to debug so they only appear in the log file, not the backlog pane.
The completion summary (✓ Complete: $issue) stays at info.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@timogilvie
Copy link
Copy Markdown
Owner Author

Challenge comparison for HOK-1403

Primary used claude-sonnet-4-6 (planner) + gpt-5.4 (coder) + claude-haiku-4-5-20251001 (reviewer) vs Challenger used claude-sonnet-4-6 (planner) + claude-sonnet-4-6 (coder) + claude-haiku-4-5-20251001 (reviewer)
Challenge type: coder-only

Recommended winner: challenger (claude-sonnet-4-6)
Other PR: #376

The task was to route branch-deletion messages into the logging section only. The challenger's fix is directly aligned: it reroutes the ✓ Closed window, ✓ Removed worktree, ✓ Deleted local branch, and ✓ Deleted remote branch log calls to the existing log "debug" level (a pattern already used for the adjacent ℹ Remote branch already deleted line). The primary instead tightens git stdout suppression (2>/dev/null>/dev/null 2>&1), which addresses a related but secondary leak, and bundles in significant unrelated changes: a new _pane_metadata_unavailable helper with call sites in agent_pane_is_ready/agent_verify_launch, and flipping persisted_phase from planning to coding in the startup runner. Those unrelated edits expand blast radius well beyond the reported bug and could regress unrelated flows. The challenger's only scope slippage is a startup-handoff test stub and expectation flip, which is narrower and less risky than the primary's behavioral changes.

@timogilvie timogilvie merged commit 947c562 into main Apr 23, 2026
3 checks passed
@timogilvie timogilvie deleted the task/deleted-branch-messages-appearing-in-task-backlog-pane-challenger branch April 23, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant