HOK-1392: Suppress noisy ready stderr logs#377
Merged
timogilvie merged 6 commits intomainfrom Apr 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printMergeConflictStatusfromtools/ready.tswhich was writing merge conflict warnings to stderr (e.g.⚠️ MERGE CONFLICT: PR #241 has conflicts with main), causing them to appear as ERROR-level log entries2>/dev/nulltogh pr checksshell commands inready-stage.tsto suppress GitHub CLI warnings (e.g.no checks reported on the '...' branch) that were leaking into logs as errorstests/launch-ready-phase.test.shto reflect that success-path stderr is no longer loggedready-stage.test.tsto verify stderr suppression ongh pr checkscallsChanges
shared/lib/ready-stage.ts— Added2>/dev/nullto twogh pr checksinvocationstools/ready.ts— RemovedprintMergeConflictStatusfunction and its call siteshared/lib/ready-stage.test.ts— Added tests verifying stderr is suppressed incheckCIStatusandgatherPRContexttests/launch-ready-phase.test.sh— Updated assertions for success-path stderr behaviortests/lifecycle-harness.test.sh/tests/lifecycle-scenarios.test.sh— Added missing_restore_inflight_task_window_if_missingstubsTest plan
ready-stage.test.tsexplicitly verify2>/dev/nullis present ongh pr checkscommandsSelf-review
review-changes.ts main --json --operating-mode normalCloses HOK-1392