Skip to content

HOK-1392: Suppress noisy ready stderr logs#377

Merged
timogilvie merged 6 commits intomainfrom
task/bug-error-in-logs
Apr 23, 2026
Merged

HOK-1392: Suppress noisy ready stderr logs#377
timogilvie merged 6 commits intomainfrom
task/bug-error-in-logs

Conversation

@timogilvie
Copy link
Copy Markdown
Owner

Summary

  • Removed printMergeConflictStatus from tools/ready.ts which was writing merge conflict warnings to stderr (e.g. ⚠️ MERGE CONFLICT: PR #241 has conflicts with main), causing them to appear as ERROR-level log entries
  • Added 2>/dev/null to gh pr checks shell commands in ready-stage.ts to suppress GitHub CLI warnings (e.g. no checks reported on the '...' branch) that were leaking into logs as errors
  • Updated tests/launch-ready-phase.test.sh to reflect that success-path stderr is no longer logged
  • Added unit tests in ready-stage.test.ts to verify stderr suppression on gh pr checks calls

Changes

  • shared/lib/ready-stage.ts — Added 2>/dev/null to two gh pr checks invocations
  • tools/ready.ts — Removed printMergeConflictStatus function and its call site
  • shared/lib/ready-stage.test.ts — Added tests verifying stderr is suppressed in checkCIStatus and gatherPRContext
  • tests/launch-ready-phase.test.sh — Updated assertions for success-path stderr behavior
  • tests/lifecycle-harness.test.sh / tests/lifecycle-scenarios.test.sh — Added missing _restore_inflight_task_window_if_missing stubs

Test plan

  • Existing test suite covers the changed paths
  • New unit tests in ready-stage.test.ts explicitly verify 2>/dev/null is present on gh pr checks commands
  • Shell test assertions updated to confirm success-path ready stderr is no longer logged as an error

Self-review

  • Review tool: review-changes.ts main --json --operating-mode normal
  • Verdict: ready (exit code 0, 0 findings)
  • Iterations: 1

Closes HOK-1392

@timogilvie timogilvie merged commit d71794f into main Apr 23, 2026
3 checks passed
@timogilvie timogilvie deleted the task/bug-error-in-logs branch April 23, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant