HOK-1391: Add explicit plan critique to eval judge#378
Merged
timogilvie merged 12 commits intomainfrom Apr 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
planCritiquerubric to the eval judge that scores plans directly across five dimensions:component_boundaries,invariant_coverage,approach_soundness,missed_patches, andoveralltools/prompts/plan-critique.mdprompt for evaluating plans in isolation (useful when you have the plan and diff but want a focused critique without running the full eval)PlanCritique/PlanCritiqueDimensionTypeScript interfaces and attaches the critique to theplanstage score when availableChanges
tools/prompts/eval-judge.md— newPlan Critiquesection instructs the judge to emitplanCritiquewhen an implementation plan artifact is presenttools/prompts/plan-critique.md— new standalone prompt for targeted plan evaluationshared/lib/eval-schema.ts— v1.9.0:PlanCritique,PlanCritiqueDimensiontypes;planCritiquefield onStageScoreshared/lib/eval-record-builder.ts—attachStageOutcomesnow accepts and attachesplanCritiqueto the plan stageshared/lib/eval-schema.test.ts,eval-record-builder.test.ts,eval.test.js,llm-cli.ts/test.ts— schema version bump and related test updatestests/lifecycle-harness.test.sh,tests/lifecycle-scenarios.test.sh— stub_restore_inflight_task_window_if_missingto fix lifecycle harness testsTest plan
eval-record-buildertests confirmplanCritiqueis attached to the plan stage when provided and omitted otherwiseplanCritiqueobject for workflows that include an implementation plan and omits it when the plan is unavailableplan-critique.mdprompt can be used directly with a task prompt + plan content + optional diffSelf-review
Closes HOK-1391