Updated BroadcastListener to set port for reuse#3
Open
ibuprofane wants to merge 1 commit intotimothyb89:masterfrom
Open
Updated BroadcastListener to set port for reuse#3ibuprofane wants to merge 1 commit intotimothyb89:masterfrom
ibuprofane wants to merge 1 commit intotimothyb89:masterfrom
Conversation
The original code was impacting Android users. If multiple apps using this code were open then only the first app would be able to connect to the socket. The new code allows the socket to be shared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code was impacting Android users. If multiple apps using this code were open then only the first app would be able to connect to the socket. The new code allows the socket to be shared.
This could be parameterized, but I think the default should be to set the socket for reuse.