Open
Conversation
The first kitty in the example app didn’t have a picture because the URL for the image wasn’t working. Updated it to a random working one and now we can see 1 more kitty in the lineup. :)
Highly recommended.
Highly recommended.
Goes hand in hand with Gradle build tools upgrade. Best to be on the most recent version.
We have it listed in package.json as ^0.41.2 so let’s make sure to use a similar approach in Gadle. Just as a reminder, 0.41+ means any versions like 0.42, 0.43, etc. which is the same meaning ^0.41.2 in package.json. According to http://ant.apache.org/ivy/history/trunk/settings/version-matchers.html
Was coming up as grey on Android.
It’s a little more playful. I like that. Also lengthed the animation to 300 so it feels more natural. Tested out elastic (no worky on Android), ease, inout, quad. I like this one the best.
Had to adjust a tonne of the styling to make this work and look good. Essentially, on iOS the shadows are just cast across any boundaries of the element, but with Android, you need to provide padding (or margin) for those shadows and scaling to come through. So, instead of having a horizontal margin on the entire SortableList, I set the horizontal margin on the rows themselves. This gives plenty of room to conduct those animations and shadows. I also added a similar scaling transform for Android, except a little smaller so we can get more of the shadow from elevation in. I tested out different elevation ranges and this looks to be about right.
Now that it shows both iOS and Android the width prop was making it too small.
Defaults to 60, but can be changed. Especially useful when row height or list is small.
Fixes one fo the big ToDos in gitim#15.
- Use `manuallyActivateRows={true}` to have the `toggleRowActive` prop exposed to rendered rows.
- The out of box timer with pan responder will not activate rows.
- This should allow for child horizontal pan responders (ie swiping).
…ay] (gitim#82) * Update SortableList.js * Update data accept PropTypes
…header and footer (gitim#92) ok, thanks for contribution, will release it soon
…itim#91) * Add renderHeader which acts the same as renderFooter but at the top * Keep trailing comma * Revert undefined check fix for separate PR
* adding hide scroll indicator props * proptypes and readme
…vateRows={true}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.