Functional visitor, Java 8, comments#84
Open
nightscape wants to merge 12 commits intotimowest:masterfrom
Open
Conversation
This gets rid of the shared mutable printer instance and its requirement to call methods in exactly the right order
Super calls in auxiliary constructors are not allowed in Scala. Replace them with a call this(???) which should either fail to compile or throw an exception when used. Also add a big fat note on what to do.
* Run compilations in parallel
* Allow filtering the files to compile by specifying a system property
(e.g. in SBT via `sys.props += ("test-compile-filter" -> "Java8")`)
* Print the generated Scala code in case of compilation errors
using JUnit's Parameterized runner.
This was referenced Jan 13, 2017
Closed
|
As the maintainer of JavaParser I would say: PLEASE merge this because your dependency is way out of date! |
* Maven: add scalafmt dependency [fix] * Maven: make the build more robust (removes some build warnings) * Maven: compile as Java 8 sources (was Java 7) [fix] * Maven: indents cleanup * Maven: update to latest scala 2.11.x (2.11.6 -> 2.11.8) * Maven plugin: cleanup (just moving things around) * Maven plugin: modernize a lot & updates & fixes * Maven plugin: make the build more robust (gets rid of some warnings) * README: update to latest version * README: add maven dev instructions * Fix small typo
This was referenced Oct 12, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @timowest,
I've dug much deeper than I initially planned and made quite some changes to scalagen, but I hope they pay off:
ScalaDumpVisitorinto a statelessScalaStringVisitorwhich instead of modifying a localSourcePrinterreturnsStrings in allvisitmethods.visitmethods implemented, so we should be able to transform Java 8 code (most likely there's some bugs in there, which we can fix as we discover them)It would be great if you could have a look at this so we can start discussing on how to integrate and release this. If I have time, I'll publish a build on Bintray so that people can already start trying this out and finding bugs 😉
Phew, that was a journey! 😄