Update Dockerfile to include sqlite inside #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainer modify Dockerfile and docker-compose.yml by including sqlite3 into docker image, so no need to install it on a host machine and create volume link to sessions.db only one thing - we should create a file on a host machine anyway, before building a container. just put in console in current directory `touch sessions.db` it creates an empty file so when container created it will update it with a command `sqlite3 sessions.db "VACUUM;"` inside a container
Contributor
|
Without a volume, this would mean that the database is empty when you recreate the container. I would say that this is not really the intention of a database. It should persist over recreating containers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify Dockerfile by including
sqliteinto docker image, so no need to install it on a host machine and create volume link to sessions.dbonly one thing - we should create a file on a host machine before building a container. just put in console in current directory
touch sessions.dbit creates an empty file so when container created it will update it with a command
sqlite3 sessions.db "VACUUM;"inside a container