Skip to content

Comments

Updated tinacms dependency mermaid#6410

Open
TihomirIvanov wants to merge 1 commit intotinacms:mainfrom
TihomirIvanov:bump-tinacms-dependency-mermaid
Open

Updated tinacms dependency mermaid#6410
TihomirIvanov wants to merge 1 commit intotinacms:mainfrom
TihomirIvanov:bump-tinacms-dependency-mermaid

Conversation

@TihomirIvanov
Copy link
Contributor

Updates packages/tinacms dependency mermaid to v11.

Fixes security vulnerabilities

@TihomirIvanov TihomirIvanov requested a review from a team as a code owner February 10, 2026 19:06
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

🦋 Changeset detected

Latest commit: db857e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
tinacms Patch
next-tinacms-azure Patch
next-tinacms-cloudinary Patch
next-tinacms-dos Patch
next-tinacms-s3 Patch
tinacms-authjs Patch
tinacms-clerk Patch
@tinacms/app Patch
@tinacms/cli Patch
@tinacms/vercel-previews Patch
playwright-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@18-th
Copy link
Collaborator

18-th commented Feb 10, 2026

Hi @TihomirIvanov, thank you for your contribution. This bump is going 2 major versions up. How was this tested?

@TihomirIvanov TihomirIvanov marked this pull request as draft February 11, 2026 15:14
@TihomirIvanov TihomirIvanov marked this pull request as ready for review February 11, 2026 15:14
@TihomirIvanov
Copy link
Contributor Author

Hi @18-th, thanks for taking a look at this PR.

I see that mermaid is used in the tinacms package in 2 places, rendering mermaid graph and code blocks with mermaid syntax inside the mdx field. Both of them can be checked in the basic-iframe example, because it contains a mermaid chart, and both worked fine. Also I made sure the E2E tests still passed, as said in the contributing guide.

I found no tests specifically for the mermaid graphs, so I didn't add any. Should there be any?

This is the list of the files that import mermaid in the tinacms package:

Also I found that mermaid is used in 3 different major versions in different places in the project:

  • packages/tinacms/package.json -> "mermaid": "9.3.0",
  • examples/next-2024/package.json -> "mermaid": "^10.9.3",
  • examples/basic-iframe/package.json -> "mermaid": "^11.7.0",

@TihomirIvanov TihomirIvanov force-pushed the bump-tinacms-dependency-mermaid branch from d5db481 to f57c71a Compare February 13, 2026 12:48
@18-th
Copy link
Collaborator

18-th commented Feb 15, 2026

Hi @TihomirIvanov, thank you for your response. This will need some manual testing since I don't believe we have any mermaid-specific tests in the repo. I will try to get around to it sometime this week or next week.

@TihomirIvanov TihomirIvanov force-pushed the bump-tinacms-dependency-mermaid branch from f57c71a to db857e3 Compare February 19, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants