Updated tinacms dependency mermaid#6410
Conversation
🦋 Changeset detectedLatest commit: db857e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @TihomirIvanov, thank you for your contribution. This bump is going 2 major versions up. How was this tested? |
|
Hi @18-th, thanks for taking a look at this PR. I see that mermaid is used in the tinacms package in 2 places, rendering mermaid graph and code blocks with mermaid syntax inside the mdx field. Both of them can be checked in the basic-iframe example, because it contains a mermaid chart, and both worked fine. Also I made sure the E2E tests still passed, as said in the contributing guide. I found no tests specifically for the mermaid graphs, so I didn't add any. Should there be any? This is the list of the files that import mermaid in the tinacms package:
Also I found that mermaid is used in 3 different major versions in different places in the project:
|
d5db481 to
f57c71a
Compare
|
Hi @TihomirIvanov, thank you for your response. This will need some manual testing since I don't believe we have any mermaid-specific tests in the repo. I will try to get around to it sometime this week or next week. |
Fixes security vulnerabilities - Fixes GHSA-p3vf-v8qc-cwcr - Fixes GHSA-gx9m-whjm-85jf - Fixes GHSA-mmhx-hmjr-r674 - Fixes GHSA-m4gq-x24j-jpmf - Fixes GHSA-vhxf-7vqr-mrjg
f57c71a to
db857e3
Compare
Updates packages/tinacms dependency mermaid to v11.
Fixes security vulnerabilities