Open
Conversation
images, but I’m missing the hover thing. Need that and I’m all set.
boxes as I want it to be.
box in the whole image as well but instead I left the new box in the top as the exercise required it.
in order to finish it with all we talked in classes last monda.
riledhel
reviewed
Apr 28, 2017
01-JS-DOM-APIs/funciones.js
Outdated
| @@ -0,0 +1,100 @@ | |||
| var Q = require('q'); | |||
There was a problem hiding this comment.
esto no está definido en ningún lado y falla ni bien cargas la página
riledhel
reviewed
Apr 28, 2017
| @@ -0,0 +1,100 @@ | |||
| var Q = require('q'); | |||
|
|
|||
| function fadein() { | |||
There was a problem hiding this comment.
No es la intención del ejercicio, se busca usar javascript para registrar un handler, browser events y CSS3
riledhel
reviewed
Apr 28, 2017
01-JS-DOM-APIs/funciones.js
Outdated
| const data= document.getElementById('excercise7'); | ||
| const url= 'http://api.icndb.com/jokes/random'; | ||
|
|
||
| fetch( url ) |
There was a problem hiding this comment.
No le estamos pasando el parámetro de configuración y la idea es usar la promesa, no un wrapper de más alto nivel
riledhel
reviewed
Apr 28, 2017
01-JS-DOM-APIs/funciones.js
Outdated
| fetch( url ) | ||
| .then(function(responsetext) { | ||
| return responsetext.json(); | ||
| }).then(function(json){ |
riledhel
reviewed
Apr 28, 2017
| } | ||
|
|
||
|
|
||
| // Exercise 7. I think it's pretty accurate of what you spect. |
riledhel
reviewed
Apr 28, 2017
01-JS-DOM-APIs/funciones.js
Outdated
| /* I don't know what I'm doing anymore. I'm gonna sleep. | ||
| then read javascript's books or die trying. :) */ | ||
| function loadXMLDoc2() { | ||
| let deferred = Q.defer(); |
There was a problem hiding this comment.
esto no funciona porque Q no se carga en ningún lugar (porque falla el require de arriba del todo)
riledhel
reviewed
Apr 28, 2017
01-JS-DOM-APIs/funciones.js
Outdated
| //this.responseText; | ||
| } | ||
| }; | ||
| xhttp.open("GET", " https://api.github.com/search/repositories", true); |
There was a problem hiding this comment.
Tampoco estamos pasando como sufijo el parámetro q=... donde le pasamos a github qué estamos buscando
search without refreshing the page.
cause I didn’t understand exactly how implement what it asked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what i had before last monday. I'm working again since exercise one to make it more accurate of what you want as a solution