Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #135.
Summary
This adds configurable cycle rings for
tinty cycle. Instead of relying on a singlepreferred-schemeslist or inferring light/dark relationships from scheme names, users can now define explicit named groups of schemes and cycle through the group they want.The issue discussion called out that suffix-based light/dark inference is unreliable because scheme names are conventions, not guaranteed metadata. Explicit rings avoid that ambiguity and also support arbitrary user-defined cycles beyond light/dark groupings.
Configuration
tinty cycleuses default-cycle-ring.tinty cycle --ring darkcycles through the named ring directly.Empty selected rings now return an error instead of applying anything.
preferred-schemespreferred-schemesis no longer used. If it is present,tinty cycleexits with a hard migration message and prints a copy/paste[[rings]]replacement that preserves the old cycle order, includingdefault-schemeprepending behavior.