feat(order): Create an ordering class for limit and recurring orders #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to differentiate between two versions of BaseClient
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an ordering class to support both limit and recurring orders while refactoring related utilities and updating client implementations. Key changes include:
- The addition of a new intToBytes utility in src/util/util.ts and its consolidation across the codebase.
- The creation of new order-specific modules (types, constants, and utilities) to support the ordering functionality.
- Updates to the TinymanBaseClient in several modules to use generics and improve error handling for missing application IDs.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/util/util.ts | Added intToBytes helper with bitwise logic and ESLint disable/enable comments. |
| src/util/client/base/* | Refactored BaseClient to use generics and improved error checking. |
| src/order/* | Introduced order utilities, types, and constants for limit and recurring orders. |
| src/liquid-stake/, src/governance/ | Updated import paths and removed duplicate intToBytes implementations. |
jamcry
reviewed
May 13, 2025
There was a problem hiding this comment.
Thanks @gulcinuras looks good overall! Left a few comments
Also added GitHub Copilot AI as a reviewer. It's not replacement for real reviewers yet but it is useful for catching small stuff like typos, or forgotten TODOs etc.
…ignerTransactions util to base client
…rotected to public
- Add version checks - Update class methods
etzellux
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.