GitHub Actions Workflows: remove Personal Access Token usage #2387
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jayaddison
commented
Dec 1, 2025
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| fetch-depth: 0 # otherwise, you will fail to push refs to dest repo | ||
| persist-credentials: false # otherwise, the token used is the GITHUB_TOKEN, instead of your personal token |
Author
There was a problem hiding this comment.
I'm taking a second look at this pull request, and I don't have a good reason why I removed the persist-credentials: false line. If we can keep it in place, then I think we should do that (minimisation of credentials and their exposure).
…eckout Partially reverts commit cffde71.
Author
|
NB: I have tested that this GitHub Actions workflow job is able to commit codestyle-lint-fixup changes after removal of the Personal Access Token, and did that by using a pull request I opened including the commits from this branch on a fork of this repository at: jayaddison#1 |
Author
|
@jackton1 ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
GITHUB_TOKENinstead of personal access tokens where possible: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#keeping-your-personal-access-tokens-securead-m/github-push-actionaction: https://github.com/step-security/secure-repo/blob/bbbbe1ee6be6264c43271e2bc4376148bf6942f6/knowledge-base/actions/ad-m/github-push-action/action-security.ymlcc @jackton1