Support longer payload messages and added ping / pong to keep alive connection#1
Open
Support longer payload messages and added ping / pong to keep alive connection#1
Conversation
…ong to keep alive connection I extended your good working websocket module to support payloads up to theoretically 4GB. I also added the ping / pong mechanism that it is possible to keep the connection alive up to an added close call. I hope this is useful, it is my first contribution on github.
There was an error in preparing the payload length field in the data header. Also pass the received opcode to the receive callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extended your good working websocket module to support payloads up to theoretically 4GB. I also added the ping / pong mechanism that it is possible to keep the connection alive up to an added close call.
I hope this is useful, it is my first contribution on github.