fix(room-server): log ERROR when add_post() returns False in _on_message_received#9
Open
fix(room-server): log ERROR when add_post() returns False in _on_message_received#9
Conversation
…age_received Previously the failure was silent: add_post() returned False, the success branch was skipped, and nothing appeared in the logs. This made it impossible to distinguish "message processed fine" from "message silently dropped" without reading the room_server logs separately. Add an else branch that logs at ERROR level with the room name, sender pubkey prefix, and the message text so that any storage failure (schema mismatch, rate limit, DB error) is immediately visible in the application logs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tjdownes
force-pushed
the
fix/room-server-logging
branch
from
1174d3f to
8927610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_post()returnsFalse(message dropped or DB error), the failure was silently ignoredTest plan