Open
Conversation
Collaborator
Author
|
One mildly annoying thing that should probably go in this commit but I don't want to do now: interface to use PLS without having to invoke Eigen. Part of the point of isolating the dependency is make it non-required; and we definitely could offer a vector + vector<vector<>> interface (which are then simply wrapped in Eigen, then passed to the other methods, with output then dropped back to vector + vector<vector<>> If that were implemented, then people could use a compiled libpls without reference to Eigen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These revisions separate out forward declaring vs using the Eigen types.
The Eigen all-header conceit is actually a bit heavy when it comes to include / compile. By manually pre-declaring only what's needed (in the proposed
pls/types.h), there can be relatively thin header files.Eigen still needs to be included to actually instantiate any objects. This also has the effect of meaning that class definition can't depend on e.g. the size of objects of that type, which means using pointers / references for fields of the Eigen types.
This also means that downstream stuff using PLS will need to include Eigen explicitly if using Eigen methods, rather than getting everything from including (bloated) pls headers.