add ability to set time offset with loading file + enhance spec for Local time #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc75
force-pushed
the
offset_time_mgt
branch
from
a9daf9e to
ae9b9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the FIT File Types description, in FIT message
activitywe can find this description forlocal_timestampI have not found a way to do that dynamically during loading, so I am proposing this PR.
It allows to load the file to get the offset and then use this offset as an input to load the file again (too bad the file has to be loaded twice).
I am using this trick for quite a while and it allows to get the proper time on file created before the garmin watch time is set properly with antfs-cli in my case.
Do not hesitate to let me know if anything need to be changed (this time I checked the
specandrubocopresults are fine ;-) )I also modified a test related to local time to make it timezone independant while checking the date itself.
I hope it will work with all time zones (not really tested)