Use AFMotion instead of Bubblewrap for HTTP#23
Open
killion wants to merge 9 commits intotkadauke:masterfrom
Open
Use AFMotion instead of Bubblewrap for HTTP#23killion wants to merge 9 commits intotkadauke:masterfrom
killion wants to merge 9 commits intotkadauke:masterfrom
Conversation
Owner
|
First of all, thanks for that pull request. I like the idea of moving towards AFMotion.
Other than that, it looks great! :-) |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This request is because Bubblewrap is removing their HTTP module:
rubymotion-community/BubbleWrap#308
I tried to change as little as possible, but "success" is returned by AFMotion instead of "ok" like Bubblewrap. So this is a breaking change. I could create a pull request on AFMotion to add an alias but "success" is actually more correct.
The specs are broken because Webstub does not support AFMotion. It's noted here:
nathankot/webstub#20
I tested with my app and the example app and I haven't found any issues. Not sure what to do about it.
It would be better to move to AFMotion's JSON parser and remove Bubblewrap entirely but that is a bigger change that I didn't want to tackle.