Open
Conversation
Owner
|
What version of Radarr do you have? I'd also like to see the tests updated to include the new attributes if any (hard to tell at a glance) or enums |
Author
|
I just cloned it and was indeed checking the tests if there were any. I currently run at 4.5.2.7388 |
Owner
|
So all the ones you marked optional you don't have? I plan on moving this package to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
I wanted to implement the diagnostics platform in HA since I was suffering from a bug, and to put the coordinator data to dict, all fields should be present, so I checked my response and it seems the current implementation is outdated.
I synced the system health object with the one described in the docs. I would also like to go over the rest when I set up my development environment
https://radarr.video/docs/api/#/System/get_api_v3_system_status
Type of change
Additional information
Checklist
make lint)