Backbone network for RetinaNet#1
Open
husseina-nvidia wants to merge 3 commits intotkornuta-nvidia:developfrom
Open
Backbone network for RetinaNet#1husseina-nvidia wants to merge 3 commits intotkornuta-nvidia:developfrom
husseina-nvidia wants to merge 3 commits intotkornuta-nvidia:developfrom
Conversation
tkornuta-nvidia
requested changes
Nov 23, 2019
Owner
There was a problem hiding this comment.
Hey, this is for sure a step in the right direction. However, there are still some improvements required, as follows:
- Full merge will involve using a script similar to the one that I have created, where:
- there is a NeMo DataLayer object that feeds the batches to the model,
- there is a Model that accepts those batches,
- we use NeMo training.
- What I see now that forward() (which NeMo uses) is empty and you are calling some execute method, which is... I do not even understand what it is doing. Spanning many threads? What for? Where is forward step of the model?
- The wrapper is not "compatible" from I/O ports definition, please take a look at the FasterRCNN create_ports()
Finally, please add retinanet-examples package as a dependency to setup.py. How do you install it? Can it be installed through pip, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.