Credentials supports and fixed bug#43
Open
ColinChargy wants to merge 2 commits intotkrajina:nwagers-EarthDataLoginfrom
Open
Credentials supports and fixed bug#43ColinChargy wants to merge 2 commits intotkrajina:nwagers-EarthDataLoginfrom
ColinChargy wants to merge 2 commits intotkrajina:nwagers-EarthDataLoginfrom
Conversation
…eds registers users.
…s not None but is converted to bool as False) for parameters srtm1_files and srtm3_files. Without this, v2.3a would be used whatever version value.
ColinChargy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request fixed a glitch with srtm1_files and srtm3_files handling from data.py which would end-up ignoring version parameter and using always SRTM v2.3a.
This also allows to specify credentials in get_data to use SRTM version which are only accessible to register users.
Any question, just ask!
Regards,
Colin Chargy