Convert inv tests to property-based tests #362
Conversation
This change replaces the manual `inv` unit test in `crates/fhe-math/src/zq/mod.rs` with a property-based test. The new test: - Uses `valid_moduli` to test general moduli. - Uses `prime_moduli` (a new strategy) to ensure the original prime cases are still covered and to test `inv` success cases. - Verifies that `inv` returns `None` for composite moduli or zero input. - Verifies that `inv` returns the correct inverse for prime moduli. - Includes debug assertions to verify panic behavior on invalid inputs (only when p is prime). Co-authored-by: tlepoint <1345502+tlepoint@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change replaces the manual `inv` unit test in `crates/fhe-math/src/zq/mod.rs` with a property-based test. The new test: - Uses `valid_moduli` to test general moduli. - Uses `prime_moduli` (a new strategy) to ensure the original prime cases are still covered and to test `inv` success cases. - Verifies that `inv` returns `None` for composite moduli or zero input. - Verifies that `inv` returns the correct inverse for prime moduli. - Includes debug assertions to verify panic behavior on invalid inputs (only when p is prime). Co-authored-by: tlepoint <1345502+tlepoint@users.noreply.github.com>
Converted the existing unit tests for
invincrates/fhe-math/src/zq/mod.rsto useproptest.Added
prime_modulistrategy to select from a list of known primes to ensureinv(which requires prime modulus) is tested on success paths.Updated the test logic to correctly handle composite moduli (where
invreturnsNone) and prime moduli.Verified that the new tests pass.
PR created automatically by Jules for task 11877419140817895403 started by @tlepoint