Closed
Conversation
Some of the types have changed subtle, so we make sure to pull in the latest versions of the sur files, and update the types we use to match.
arthyn
approved these changes
May 30, 2024
Member
arthyn
left a comment
arthyn
left a comment
There was a problem hiding this comment.
was really confused until I realized this was landscape, lgtm
Member
Author
That happened in #311. Closing as such. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activity summarization had broken down. Some of the types have changed subtly, so we make sure to pull in the latest versions of the sur files, and update the types we use to match.
The
/surfiles here are straight copies from their tloncorp/tlon-apps counterparts. Notably the previous versions predate type cleanup and%channelsscry api versioning, so hopefully this'll be more stable going forward.Closes TLON-1937 upon release.
(This mostly wouldn't be necessary (and get caught much earlier) if we moved this into the groups desk, as we should. Soon...)