Adding compatibility fix for lodash and underscore#279
Open
connorjburton wants to merge 1 commit intotlovett1:masterfrom
Open
Adding compatibility fix for lodash and underscore#279connorjburton wants to merge 1 commit intotlovett1:masterfrom
connorjburton wants to merge 1 commit intotlovett1:masterfrom
Conversation
Contributor
Author
|
Hi @tlovett1 - have you managed to look at this yet? This is a form breaking issue and should be pretty easy to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue when
underscoreandlodashare in the same global scope, whenform.min.jsfirst loads_is defined asunderscore. However, when the rest of the page loads (and lodash), it will overwrite_tolodash, which means when you click the submit button you get an error to do with the_.each(arg, callable, context), asunderscorehas the thirdcontextparameter, yetlodashdoesn't.As you can see, that is an issue! I have used
_.noConflict()to ensure what we use at the start ofform.jswe use throughout the file.