Sourcery Starbot ⭐ refactored tma15/python-tabelog #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Feb 4, 2023
| return prefecture_map[prefecture] | ||
| except KeyError: | ||
| sys.exit('invalid prefecture name: %s' % prefecture) | ||
| sys.exit(f'invalid prefecture name: {prefecture}') |
Author
There was a problem hiding this comment.
Function convert2prefecture_parameter refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
Comment on lines
-57
to
+80
| _request_url = 'http://api.tabelog.com/Ver2.1/RestaurantSearch/?Key=%s' % self._access_key | ||
| _request_url = f'http://api.tabelog.com/Ver2.1/RestaurantSearch/?Key={self._access_key}' | ||
| if latitude: | ||
| _request_url = "%sLatitude=%f" % (_request_url, float(latitude)) | ||
| if longitude: | ||
| _request_url = "%sLongitude=%f" % (_request_url, float(longitude)) | ||
| if datum and latitude and longitude: ### valid if both latitude and longitude are specified | ||
| _request_url = "%sDatum=%s" % (self._request_url, str(datum)) | ||
| _request_url = f"{self._request_url}Datum={str(datum)}" | ||
| if search_range: | ||
| _request_url = "%sSearchRange=%s" % (_request_url, str(search_range)) | ||
| _request_url = f"{_request_url}SearchRange={str(search_range)}" | ||
| if prefecture: | ||
| _request_url = "%s&Prefecture=%s" % (_request_url, str(convert2prefecture_parameter(prefecture))) | ||
| _request_url = f"{_request_url}&Prefecture={str(convert2prefecture_parameter(prefecture))}" | ||
| if station: | ||
| query = [('Station', station)] | ||
| _request_url = "%s&%s" % (_request_url, urllib.urlencode(query)) | ||
| _request_url = f"{_request_url}&{urllib.urlencode(query)}" | ||
| if result_set: | ||
| _request_url = "%s&ResultSet=%s" % (_request_url, str(result_set)) | ||
| _request_url = f"{_request_url}&ResultSet={str(result_set)}" | ||
| if sort_order: | ||
| _request_url = "%s&SortOrder=%s" % (_request_url, str(sort_order)) | ||
| _request_url = f"{_request_url}&SortOrder={str(sort_order)}" | ||
| if page_num: | ||
| _request_url = "%s&PageNum=%d" % (_request_url, str(page_num)) | ||
| if result_datum: | ||
| _request_url = "%s&ResultDatum=%d" % (_request_url, str(result_datum)) | ||
| _search_results = self._extract_items(_request_url) | ||
| _restaurants = [Restaurant(item) for item in _search_results] | ||
| return _restaurants | ||
| return [Restaurant(item) for item in _search_results] |
Author
There was a problem hiding this comment.
Function Tabelog.search_restaurant refactored with the following changes:
- Replace interpolated string formatting with f-string [×7] (
replace-interpolation-with-fstring) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-86
to
+89
| _request_url = "%s&SortOrder=%s" % (_request_url, sort_order) | ||
| _request_url = f"{_request_url}&SortOrder={sort_order}" | ||
| if page_num: | ||
| _request_url = "%s&PageNum=%d" % (_request_url, int(page_num)) | ||
| _search_results = self._extract_items(_request_url) | ||
| _reviews = [Review(item) for item in _search_results] | ||
| return _reviews | ||
| return [Review(item) for item in _search_results] |
Author
There was a problem hiding this comment.
Function Tabelog.search_review refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-96
to
+94
| images = [Image(item) for item in _search_results] | ||
| return images | ||
| return [Image(item) for item in _search_results] |
Author
There was a problem hiding this comment.
Function Tabelog.search_restaurant_image refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-119
to
+116
| if self._rcd == None: | ||
| if self._rcd is None: |
Author
There was a problem hiding this comment.
Function Restaurant.rcd refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
Comment on lines
-193
to
+190
| if self._category == None: | ||
| if self._category is None: |
Author
There was a problem hiding this comment.
Function Restaurant.category refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
Comment on lines
-199
to
+196
| if self._station == None: | ||
| if self._station is None: |
Author
There was a problem hiding this comment.
Function Restaurant.station refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
Comment on lines
-224
to
+221
| if self._nickname == None: | ||
| if self._nickname is None: |
Author
There was a problem hiding this comment.
Function Review.nickname refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
Comment on lines
-230
to
+227
| if self._visitdate == None: | ||
| if self._visitdate is None: |
Author
There was a problem hiding this comment.
Function Review.visitdate refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
Comment on lines
-236
to
+233
| if self._reviewdate == None: | ||
| if self._reviewdate is None: |
Author
There was a problem hiding this comment.
Function Review.reviewdate refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: