Fix X509 parsing vulnerabilities #782
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a security vulnerability in sig_verify() function that was cloned from axTLS but did not receive the security patch.
The original issue was reported and fixed in the axTLS repository under commit 5efe2947ab45e81d84b5f707c51d1c64be52f36c. This PR applies a similar patch to eliminate the buffer overflow vulnerability.
References
https://nvd.nist.gov/vuln/detail/CVE-2018-16149
https://nvd.nist.gov/vuln/detail/CVE-2018-16150
igrr/axtls-8266@5efe294