Skip to content

145 bug report#164

Open
skokaina wants to merge 2 commits intosnapshotfrom
145_bug_report
Open

145 bug report#164
skokaina wants to merge 2 commits intosnapshotfrom
145_bug_report

Conversation

@skokaina
Copy link
Copy Markdown
Member

@skokaina skokaina commented Feb 3, 2018

No description provided.

if(erreur == 0.0) {
throw new IllegalAccessError();
}
System.out.println("");
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this use of System.out or System.err by a logger. rule


public String name;

public Double erreur;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Make erreur a static final constant or non-public and provide accessors if needed. rule

items.stream().forEach(o -> items.add(o.toString()));
}

private void codepouri() {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Remove this unused private "codepouri" method. rule

}

private void codepouri() {
if(erreur.equals("")) {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Remove this call to "equals"; comparisons between unrelated types always return false. rule

@skokaina
Copy link
Copy Markdown
Member Author

skokaina commented Feb 3, 2018

SonarQube analysis reported 4 issues

  • MAJOR 3 major
  • MINOR 1 minor

Watch the comments in this conversation to review them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant