Implement error bars using standard deviation on timeline plots#204
Implement error bars using standard deviation on timeline plots#204str4d wants to merge 1 commit intotobami:masterfrom
Conversation
|
Two things:
|
|
Reviewing #203 ... One thought occurred to me: before trying to re-add a complex feature like error bars, do you think it makes sense to reevaluate now what plotting library we use? jqPlot has been unmaintained for over two years now. |
|
I don't personally have an opinion. I've never used any JavaScript plotting libraries prior to setting codespeed up; since then I have now used jqPlot and d3, but only just enough to get the features I wanted working 😜 |
|
Ah, it seemed like you had experience with plotting libraries! Let's leave that question for now then. |
|
@str4d are you going to rebase this branch onto master? |
|
Sorry for the delay, work's been keeping me busy. I'll do this Friday 😄 |
|
I'm also interested in this change, therefore a kind ping @str4d :-) |
|
Ok, I merged it quickly, it works for me but since I don't know the internals of codespeed, I can't tell if I broke something. |
|
Nice, thanks @tnorth! I'll do some "visual" testing of it 😄 |
|
Sorry for dropping the ball on this! I'll be doing some more codespeed work in the next few weeks, so I'll get this integrated while I do :) |
|
Rebased on 0.11.0 (because that's what I've been working from locally), and fortunately there are no merge conflicts with master! |
|
Could you rebase on top of master just in case? I merged some big refactors affecting default branches. |
jqplot.ohlcRendererWithErrorBars.min.js is the standard OHLC Renderer plugin from jqPlot 1.0.9 (revision d96a669) with the error-bar addition given here: https://bitbucket.org/cleonello/jqplot/issues/35/add-error-bar-capability#comment-141580
|
Rebased on master, still appears to work for me! |
|
That padding change appears to be left over from the original PR #113 (see e.g. #113 (comment)). I can try playing around with the contents, but not being the original author I don't immediately know the cause. |


Recreated from #113 on current master.